Merged
Conversation
Member
Author
|
Note: we should probably also add "build on a 32-bit platform" to the CI after this pull request. Also, perhaps the bindgen scripts might also be removed (or move to a "tools" directory for future reference), since running bindgen shouldn't be needed any more. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 57.36% 57.78% +0.41%
==========================================
Files 74 74
Lines 10559 10590 +31
==========================================
+ Hits 6057 6119 +62
+ Misses 4502 4471 -31 ☔ View full report in Codecov by Sentry. |
…ill have the type c_int
squell
force-pushed
the
portable-c-binding
branch
from
63f72bc to
326e996
Compare
squell
force-pushed
the
portable-c-binding
branch
from
66d11f5 to
3260252
Compare
pvdrz
approved these changes
Jan 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will close #818 (verified on i386).
Note that the bindgen self-test that I edited don't really add much value: they're essentially testing that the
[repr(C)]layout is as we expect it to be, but they go a bit beyond what a C compiler would have to guarantee; and even if the layout of these structs is different, it would still mean our PAM bindings would be correct anyway. The only important bit is that the Rust spec given matches the actual C prototypes.Which is a given, since PAM is an extremely stable API.
This can be reviewed commit-by-commit.